Construct and_exprt in a non-deprecated way #3786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
martin-cs,
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
force-pushed
the
deprecation-and_exprt
branch
from
06eb157 to
f904bcc
Compare
allredj
reviewed
Jan 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: f904bcc).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97160884
kroening
reviewed
Jan 13, 2019
src/solvers/flattening/functions.cpp
Outdated
| @@ -35,18 +35,17 @@ exprt functionst::arguments_equal(const exprt::operandst &o1, | |||
| if(o1.empty()) | |||
| return true_exprt(); | |||
|
|
|||
There was a problem hiding this comment.
The if above can go away; conjunction() takes care of this.
kroening
reviewed
Jan 13, 2019
| and_exprt result; | ||
| result.operands()=op; | ||
| return std::move(result); | ||
| return and_exprt(exprt::operandst(op)); | ||
| } |
There was a problem hiding this comment.
The cast appears to be redundant.
There was a problem hiding this comment.
That's necessary to as the and_exprt constructor wants an rvalue reference.
kroening
approved these changes
Jan 13, 2019
The default constructor is deprecated. To facilitate construction with an arbitrary number of operands a new constructor taking a initializer list is added.
tautschnig
force-pushed
the
deprecation-and_exprt
branch
from
f904bcc to
4819fda
Compare
allredj
reviewed
Jan 14, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4819fda).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97277964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default constructor is deprecated. To facilitate construction with an
arbitrary number of operands a new constructor taking a initializer list is
added.